Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262150AbVCIR4p (ORCPT ); Wed, 9 Mar 2005 12:56:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262151AbVCIR4p (ORCPT ); Wed, 9 Mar 2005 12:56:45 -0500 Received: from mail-in-01.arcor-online.net ([151.189.21.41]:34702 "EHLO mail-in-01.arcor-online.net") by vger.kernel.org with ESMTP id S262150AbVCIR4o (ORCPT ); Wed, 9 Mar 2005 12:56:44 -0500 From: Bodo Eggert <7eggert@gmx.de> Subject: RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers To: Bagalkote@arcor-online.net, Sreenivas , linux-kernel@vger.kernel.org Reply-To: 7eggert@gmx.de Date: Wed, 09 Mar 2005 18:59:22 +0100 References: User-Agent: KNode/0.7.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 16 Bagalkote, Sreenivas wrote: >>> . And since this is compile time >>> system-wide property, I kept it as driver global. >> >>that step I don't understand... why is it a global *VARIABLE* if it's >>compile time system-wide property... >> > > I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8) > instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier? > Please advice. If using a static const variable produces about the same code a macro does, the variable is OK. Otherwise you'll have to use a #define in order to avoid including dead code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/