Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262334AbVCIX5D (ORCPT ); Wed, 9 Mar 2005 18:57:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262301AbVCIX43 (ORCPT ); Wed, 9 Mar 2005 18:56:29 -0500 Received: from e32.co.us.ibm.com ([32.97.110.130]:8365 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S262334AbVCIXwH (ORCPT ); Wed, 9 Mar 2005 18:52:07 -0500 Subject: Re: [PATCH 2/2] readahead: improve sequential read detection From: Ram To: Oleg Nesterov Cc: linux-kernel@vger.kernel.org, Steven Pratt , Andrew Morton In-Reply-To: <42260F30.BE15B4DA@tv-sign.ru> References: <42260F30.BE15B4DA@tv-sign.ru> Content-Type: text/plain Organization: IBM Message-Id: <1110412324.4816.89.camel@localhost> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 09 Mar 2005 15:52:04 -0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 27 On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote: ..snip... > @@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac > } > > out: > - return newsize; > + return ra->prev_page + 1; This change introduces one key behavioural change in page_cache_readahead(). Instead of returning the number-of-pages successfully read, it now returns the next-page-index which is yet to be read. Was this essential? At least, a comment towards this effect at the top of the function is worth adding. RP - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/