Message-ID: <422F8EBE.5080803@austin.ibm.com>
Date: Wed, 09 Mar 2005 18:03:10 -0600
From: Steven Pratt <slpratt@austin.ibm.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Ram <linuxram@us.ibm.com>
CC: Oleg Nesterov <oleg@tv-sign.ru>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] readahead: improve sequential read detection
References: <42260F30.BE15B4DA@tv-sign.ru> <1110412324.4816.89.camel@localhost>
In-Reply-To: <1110412324.4816.89.camel@localhost>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 901
Lines: 42

Ram wrote:

>On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote:
>
>
>..snip...
>
>  
>
>>@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac
>> 	}
>> 
>> out:
>>-	return newsize;
>>+	return ra->prev_page + 1;
>>    
>>
>
>This change introduces one key behavioural change in
>page_cache_readahead(). Instead of returning the number-of-pages
>successfully read, it now returns the next-page-index which is yet to be
>read. Was this essential? 
>
>  
>
and unless filmap.c was changed accordingly this is broken..  need. to 
look at this more.

Steve

>At least, a comment towards this effect at the top of the function is
>worth adding.
>
>RP
>  
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/