Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261707AbVCJFqo (ORCPT ); Thu, 10 Mar 2005 00:46:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261685AbVCJFou (ORCPT ); Thu, 10 Mar 2005 00:44:50 -0500 Received: from holly.csn.ul.ie ([136.201.105.4]:24301 "EHLO holly.csn.ul.ie") by vger.kernel.org with ESMTP id S262483AbVCIWUC (ORCPT ); Wed, 9 Mar 2005 17:20:02 -0500 Date: Wed, 9 Mar 2005 22:20:02 +0000 (GMT) From: Dave Airlie X-X-Sender: airlied@skynet To: stable@kernel.org Cc: linux-kernel@vger.kernel.org Subject: [patch] drm missing memset can crash X server.. Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 25 Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes... From: Egbert Eich Signed-off-by: Dave Airlie diff -Nru a/drivers/char/drm/drm_ioctl.c b/drivers/char/drm/drm_ioctl.c --- a/drivers/char/drm/drm_ioctl.c 2005-03-09 10:53:42 +11:00 +++ b/drivers/char/drm/drm_ioctl.c 2005-03-09 10:53:43 +11:00 @@ -326,6 +326,8 @@ DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv)); + memset(&version, 0, sizeof(version)); + dev->driver->version(&version); retv.drm_di_major = DRM_IF_MAJOR; retv.drm_di_minor = DRM_IF_MINOR; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/