Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262714AbVCJRSV (ORCPT ); Thu, 10 Mar 2005 12:18:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262742AbVCJRQY (ORCPT ); Thu, 10 Mar 2005 12:16:24 -0500 Received: from extgw-uk.mips.com ([62.254.210.129]:11526 "EHLO mail.linux-mips.net") by vger.kernel.org with ESMTP id S262753AbVCJRPM (ORCPT ); Thu, 10 Mar 2005 12:15:12 -0500 Date: Thu, 10 Mar 2005 17:14:29 +0000 From: Ralf Baechle To: akpm@osdl.org Cc: greg@kroah.com, linux-kernel@vger.kernel.org, yuasa@hh.iij4u.or.jp Subject: Re: [patch 4/5] audit mips fix Message-ID: <20050310171429.GB26269@linux-mips.org> References: <200503042117.j24LHI7l017973@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503042117.j24LHI7l017973@shell0.pdx.osdl.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 21 On Fri, Mar 04, 2005 at 01:16:57PM -0800, akpm@osdl.org wrote: > Signed-off-by: Yoichi Yuasa > Signed-off-by: Andrew Morton > @@ -307,7 +308,7 @@ asmlinkage void do_syscall_trace(struct > { > if (unlikely(current->audit_context)) { > if (!entryexit) > - audit_syscall_entry(current, regs->orig_eax, > + audit_syscall_entry(current, regs->regs[2], Wrong. regs[2] can will contain the syscall return value and can be modified by ptrace also. Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/