Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262924AbVCJW4B (ORCPT ); Thu, 10 Mar 2005 17:56:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263421AbVCJWwZ (ORCPT ); Thu, 10 Mar 2005 17:52:25 -0500 Received: from omx1-ext.sgi.com ([192.48.179.11]:178 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S263361AbVCJWqy (ORCPT ); Thu, 10 Mar 2005 17:46:54 -0500 Date: Thu, 10 Mar 2005 14:46:27 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Dave Hansen cc: Andrew Morton , Linux Kernel Mailing List , Mel Gorman Subject: Re: [PATCH] add a clear_pages function to clear pages of higher order In-Reply-To: <1110490683.24355.17.camel@localhost> Message-ID: References: <1110490683.24355.17.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1130 Lines: 32 On Thu, 10 Mar 2005, Dave Hansen wrote: > > +extern void clear_pages (void *page, int order); > > extern void copy_page (void *to, void *from); > > +#define clear_page(__page) clear_pages(__page, 0) > > +#define __HAVE_ARCH_CLEAR_PAGES > > Although this is a simple instance, could this please be done in a > Kconfig file? If that #define happens inside of other #ifdefs, it can > be quite hard to decipher the special .config incantation to get it set. > On the other hand, if the dependencies are spelled out in a Kconfig > entry... Ok will do. > BTW, I tried applying this to 2.6.11-bk6, and it rejected: > ... > patching file include/asm-i386/page.h > Hunk #2 FAILED at 28. > 1 out of 2 hunks FAILED -- saving rejects to file > include/asm-i386/page.h.rej > ... > > There were some more rejects as well. Were there some other patches > applied first? Patches work fine here. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/