Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263293AbVCKClk (ORCPT ); Thu, 10 Mar 2005 21:41:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263292AbVCKCli (ORCPT ); Thu, 10 Mar 2005 21:41:38 -0500 Received: from gate.crashing.org ([63.228.1.57]:11735 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S263293AbVCKClK (ORCPT ); Thu, 10 Mar 2005 21:41:10 -0500 Subject: Re: AGP bogosities From: Benjamin Herrenschmidt To: Dave Jones Cc: Paul Mackerras , Linus Torvalds , Linux Kernel list In-Reply-To: <20050311021248.GA20697@redhat.com> References: <16944.62310.967444.786526@cargo.ozlabs.ibm.com> <20050311021248.GA20697@redhat.com> Content-Type: text/plain Date: Fri, 11 Mar 2005 13:35:40 +1100 Message-Id: <1110508541.32525.314.camel@gaston> Mime-Version: 1.0 X-Mailer: Evolution 2.0.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 25 > > This part I'm not so sure about. > The pci_get_class() call a few lines above will get a refcount that > we will now never release. We will ... on the next loop iteration when we call pci_get_class again. > Thanks for taking a look at this. The absense of hardware to test > on means I pretty much rely on feedback from inclusion in -mm > to hear about problems like this before it hits mainline. > Unfortunatly, no-one with ppc64 tested it there it seems :-( And ppc32, and probably others... I have seen AGP layed out differently in quite a few cases.... Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/