Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263128AbVCKCrD (ORCPT ); Thu, 10 Mar 2005 21:47:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263130AbVCKCqo (ORCPT ); Thu, 10 Mar 2005 21:46:44 -0500 Received: from mx1.redhat.com ([66.187.233.31]:29133 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S263320AbVCKCnF (ORCPT ); Thu, 10 Mar 2005 21:43:05 -0500 Date: Thu, 10 Mar 2005 21:43:00 -0500 From: Dave Jones To: Benjamin Herrenschmidt Cc: Paul Mackerras , Linus Torvalds , Linux Kernel list Subject: Re: AGP bogosities Message-ID: <20050311024259.GD20697@redhat.com> Mail-Followup-To: Dave Jones , Benjamin Herrenschmidt , Paul Mackerras , Linus Torvalds , Linux Kernel list References: <16944.62310.967444.786526@cargo.ozlabs.ibm.com> <20050311021248.GA20697@redhat.com> <1110508541.32525.314.camel@gaston> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1110508541.32525.314.camel@gaston> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 18 On Fri, Mar 11, 2005 at 01:35:40PM +1100, Benjamin Herrenschmidt wrote: > > > > > This part I'm not so sure about. > > The pci_get_class() call a few lines above will get a refcount that > > we will now never release. > > We will ... on the next loop iteration when we call pci_get_class again. Ohhh, duh. Yes. now I follow. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/