Subject: Re: [PATCH] updated, ethernet-bridge: update skb->priority in case
	forwarded frame has VLAN-header
From: jamal <hadi@cyberus.ca>
Reply-To: hadi@cyberus.ca
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "leo.yuriev.ru" <leo@yuriev.ru>,
       Lennert Buytenhek <buytenh@wantstofly.org>,
       Patrick McHardy <kaber@trash.net>, Ben Greear <greearb@candelatech.com>,
       netdev@oss.sgi.com, linux-kernel@vger.kernel.org
In-Reply-To: <20050311093724.6c8b6a6d@dxpl.pdx.osdl.net>
References: <914610115.20050311172022@yuriev.ru>
	 <20050311093724.6c8b6a6d@dxpl.pdx.osdl.net>
Content-Type: text/plain
Organization: jamalopolous
Message-Id: <1110566077.1071.16.camel@jzny.localdomain>
Mime-Version: 1.0
Date: 11 Mar 2005 13:34:37 -0500
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1102
Lines: 33


Actually there is a case to be made for this to be part of the
bridge code. A VLAN is a single collision domain which is mappable to a
collission domain that is a bridge.
infact the old VLAN code written by Lennert (and somebody else) had
those two intermingled.

cheers,
jamal

On Fri, 2005-03-11 at 12:37, Stephen Hemminger wrote:
> On Fri, 11 Mar 2005 17:20:22 +0300
> Leo Yuriev <leo@yuriev.ru> wrote:
> 
> > Kernel 2.6 (2.6.11)
> > 
> > When ethernet-bridge forward a packet and such ethernet-frame has
> > VLAN-tag, bridge should update skb->prioriry for properly QoS
> > handling. This small patch does this.
> > 
> > Based upon discussion during last week I added pskb_may_pull()
> > checking and simple mapping from 802.1p/user_priority to skb->priority.
> > 
> > Patch-by: Leo Yuriev <leo@yuriev.ru>
> 
> Do this as an ebtables module please.
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/