Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261396AbVCMRaP (ORCPT ); Sun, 13 Mar 2005 12:30:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261399AbVCMRaP (ORCPT ); Sun, 13 Mar 2005 12:30:15 -0500 Received: from smtp818.mail.sc5.yahoo.com ([66.163.170.4]:17078 "HELO smtp818.mail.sc5.yahoo.com") by vger.kernel.org with SMTP id S261396AbVCMRaK convert rfc822-to-8bit (ORCPT ); Sun, 13 Mar 2005 12:30:10 -0500 From: Dmitry Torokhov To: =?utf-8?q?Pawe=C5=82_Sikora?= Subject: Re: [2.6.11.3] gcc4 / psmouse.h - compilation fix. Date: Sun, 13 Mar 2005 12:30:03 -0500 User-Agent: KMail/1.7.2 Cc: linux-kernel@vger.kernel.org, akpm@osdl.org References: <200503131420.12554.pluto@pld-linux.org> <200503131148.46417.dtor_core@ameritech.net> <200503131754.31244.pluto@pld-linux.org> In-Reply-To: <200503131754.31244.pluto@pld-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200503131230.03938.dtor_core@ameritech.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 29 On Sunday 13 March 2005 11:54, Paweł Sikora wrote: > On Sunday 13 of March 2005 17:48, Dmitry Torokhov wrote: > > On Sunday 13 March 2005 08:20, Paweł Sikora wrote: > > > Hi, > > > > > > Attched patch fixes gcc error: > > > `drivers/input/mouse/psmouse.h:40: error: field `ps2dev' has incomplete > > > type` > > > > What file fails compilation? > > custom patch for trackpoint device. > > > As far as I can see all users of psmouse.h do > > #include first. > > IMHO each header (e.g. psmouse.h) should include headers for types it uses. > Hmm, I thought it was other way around to make it easier to track all users of a particular header file. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/