Date: Mon, 14 Mar 2005 12:35:15 -0600
From: Greg Howard <ghoward@sgi.com>
To: Jesse Barnes <jbarnes@engr.sgi.com>
cc: domen@coderock.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
       nacc@us.ibm.com
Subject: Re: [patch 01/14] char/snsc: reorder set_current_state() and
 add_wait_queue()
In-Reply-To: <200503140945.44323.jbarnes@engr.sgi.com>
Message-ID: <Pine.SGI.4.58.0503141226440.106301@gallifrey.americas.sgi.com>
References: <20050306223616.C82751EC90@trashy.coderock.org>
 <200503140945.44323.jbarnes@engr.sgi.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 916
Lines: 22


On Mon, 14 Mar 2005, Jesse Barnes wrote:

> On Sunday, March 6, 2005 2:36 pm, domen@coderock.org wrote:
> > Any comments would be, as always, appreciated.
>
> I don't have a problem with this change, but the maintainer probably should
> have been Cc'd.  Greg, does this change look ok to you?  Note that it's
> already been committed to the upstream tree, so if it's a bad change we'll
> need to have the cset excluded or something.

I think it's safe enough.  Since interrupts are off at this point,
I don't think the order of the two functions actually matters (i.e.
we couldn't have received a signal until the call to
spin_unlock_irqrestore() anyway).

Thanks - Greg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/