Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262354AbVCOJWi (ORCPT ); Tue, 15 Mar 2005 04:22:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262356AbVCOJWi (ORCPT ); Tue, 15 Mar 2005 04:22:38 -0500 Received: from mail.tv-sign.ru ([213.234.233.51]:34176 "EHLO several.ru") by vger.kernel.org with ESMTP id S262354AbVCOJWg (ORCPT ); Tue, 15 Mar 2005 04:22:36 -0500 Message-ID: <4236B8B2.AD69714@tv-sign.ru> Date: Tue, 15 Mar 2005 13:28:02 +0300 From: Oleg Nesterov X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.20 i686) X-Accept-Language: en MIME-Version: 1.0 To: Christoph Lameter Cc: Andrew Morton , linux-kernel@vger.kernel.org, Shai Fultheim , Ingo Molnar Subject: Re: [patch] del_timer_sync scalability patch References: <4231E959.141F7D85@tv-sign.ru> <42343C61.6A1210C0@tv-sign.ru> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 23 Christoph Lameter wrote: > > @@ -476,6 +454,7 @@ repeat: > } > } > spin_lock_irq(&base->lock); > + timer->running = 0; ^^^^^^^^^^^^^^^^^^ > goto repeat; > } > } This is imho wrong. The timer probably don't exist when timer_list->function returns. I mean, timer_list->function could deallocate timer's memory. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/