Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262518AbVCPFE3 (ORCPT ); Wed, 16 Mar 2005 00:04:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262522AbVCPFE3 (ORCPT ); Wed, 16 Mar 2005 00:04:29 -0500 Received: from 209-204-138-32.dsl.static.sonic.net ([209.204.138.32]:1030 "EHLO graphe.net") by vger.kernel.org with ESMTP id S262518AbVCPFE0 (ORCPT ); Wed, 16 Mar 2005 00:04:26 -0500 Date: Tue, 15 Mar 2005 21:04:24 -0800 (PST) From: Christoph Lameter X-X-Sender: christoph@server.graphe.net To: Andrew Morton cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Replace zone padding with a definition in cache.h In-Reply-To: <20050315202331.008ec856.akpm@osdl.org> Message-ID: References: <20050315202331.008ec856.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 23 On Tue, 15 Mar 2005, Andrew Morton wrote: > Christoph Lameter wrote: > > > > +#ifndef ____cacheline_pad_in_smp > > +#if defined(CONFIG_SMP) > > +#define ____cacheline_pad_in_smp struct { char x; } ____cacheline_maxaligned_in_smp > > +#else > > +#define ____cacheline_pad_in_smp > > +#endif > > +#endif > > That's going to spit a warning with older gcc's. "warning: unnamed > struct/union that defines no instances". > Is it really that important? If the struct is named then there may be conflicts if its used repeatedly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/