Date: Tue, 15 Mar 2005 21:23:37 -0800
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <christoph@lameter.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace zone padding with a definition in cache.h
Message-Id: <20050315212337.5484f2a0.akpm@osdl.org>
In-Reply-To: <Pine.LNX.4.58.0503152103580.6087@server.graphe.net>
References: <Pine.LNX.4.58.0503152010190.5134@server.graphe.net>
	<20050315202331.008ec856.akpm@osdl.org>
	<Pine.LNX.4.58.0503152103580.6087@server.graphe.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 33

Christoph Lameter <christoph@lameter.com> wrote:
>
> On Tue, 15 Mar 2005, Andrew Morton wrote:
> 
> > Christoph Lameter <christoph@lameter.com> wrote:
> > >
> > >  +#ifndef ____cacheline_pad_in_smp
> > >  +#if defined(CONFIG_SMP)
> > >  +#define ____cacheline_pad_in_smp struct { char  x; } ____cacheline_maxaligned_in_smp
> > >  +#else
> > >  +#define ____cacheline_pad_in_smp
> > >  +#endif
> > >  +#endif
> >
> > That's going to spit a warning with older gcc's.  "warning: unnamed
> > struct/union that defines no instances".
> >
> Is it really that important?

Well, it makes gcc-2.95.x unusable, and a number of people like to use it.

It has not proven too burdensome to support.  And we know that if it works
on 2.95.x, it will work on 3.1, 3.2, 3.3, etc.

> If the struct is named then there may be
> conflicts if its used repeatedly.

Hence the "hack" which you just deleted ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/