Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262288AbVCPHue (ORCPT ); Wed, 16 Mar 2005 02:50:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262289AbVCPHue (ORCPT ); Wed, 16 Mar 2005 02:50:34 -0500 Received: from ms-smtp-02.nyroc.rr.com ([24.24.2.56]:42217 "EHLO ms-smtp-02.nyroc.rr.com") by vger.kernel.org with ESMTP id S262288AbVCPHu2 (ORCPT ); Wed, 16 Mar 2005 02:50:28 -0500 Date: Wed, 16 Mar 2005 02:50:17 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@localhost.localdomain Reply-To: rostedt@goodmis.org To: Lee Revell cc: Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01 In-Reply-To: <1110913778.17931.2.camel@mindpipe> Message-ID: References: <1110574019.19093.23.camel@mindpipe> <1110578809.19661.2.camel@mindpipe> <20050315120053.GA4686@elte.hu> <20050315133540.GB4686@elte.hu> <1110913778.17931.2.camel@mindpipe> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 30 On Tue, 15 Mar 2005, Lee Revell wrote: > On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: > > Damn! The answer was right there in front of my eyes! Here's the cleanest > > solution. I forgot about wait_on_bit_lock. I've converted all the locks > > to use this instead. We probably need to get priority inheritence working > > on this too someday, but for now it's better than wasting memory or > > getting into deadlocks. > > > > I am still not clear on why this did not hit with earlier kernels + > PREEMPT_DESKTOP. Were the bitlocks introduced recently? Or was another > lock-break patch dropped? > When did you start seeing this? This code has been there as far back as 2.6.7 (the earliest 2.6 kernel I still have laying around) and as far back as Ingo's realtime-preempt-2.6.9-mm1-U10. Maybe the tracing didn't start picking this up till later, or that you were just lucky that no contention was happening on that lock. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/