Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262315AbVCPKEh (ORCPT ); Wed, 16 Mar 2005 05:04:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262323AbVCPKEh (ORCPT ); Wed, 16 Mar 2005 05:04:37 -0500 Received: from fire.osdl.org ([65.172.181.4]:40862 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262315AbVCPKEa (ORCPT ); Wed, 16 Mar 2005 05:04:30 -0500 Date: Wed, 16 Mar 2005 02:04:08 -0800 From: Andrew Morton To: Ingo Molnar Cc: rostedt@goodmis.org, rlrevell@joe-job.com, linux-kernel@vger.kernel.org Subject: Re: [patch 0/3] j_state_lock, j_list_lock, remove-bitlocks Message-Id: <20050316020408.434cc620.akpm@osdl.org> In-Reply-To: <20050316095155.GA15080@elte.hu> References: <20050315120053.GA4686@elte.hu> <20050315133540.GB4686@elte.hu> <20050316085029.GA11414@elte.hu> <20050316011510.2a3bdfdb.akpm@osdl.org> <20050316095155.GA15080@elte.hu> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 20 Ingo Molnar wrote: > > > There's a little lock ranking diagram in jbd.h which tells us that > > these locks nest inside j_list_lock and j_state_lock. So I guess > > you'll need to turn those into semaphores. > > indeed. I did this (see the three followup patches, against BK-curr), > and it builds/boots/works just fine on an ext3 box. Do we want to try > this in -mm? ooh, I'd rather not. I spent an intense three days removing all the sleeping locks from ext3 (and three months debugging the result). Ended up gaining 1000% on 16-way. Putting them back in will really hurt the SMP performance. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/