Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262544AbVCPLFu (ORCPT ); Wed, 16 Mar 2005 06:05:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262548AbVCPLFu (ORCPT ); Wed, 16 Mar 2005 06:05:50 -0500 Received: from ms-smtp-03.nyroc.rr.com ([24.24.2.57]:40903 "EHLO ms-smtp-03.nyroc.rr.com") by vger.kernel.org with ESMTP id S262544AbVCPLFe (ORCPT ); Wed, 16 Mar 2005 06:05:34 -0500 Date: Wed, 16 Mar 2005 06:05:09 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@localhost.localdomain Reply-To: rostedt@goodmis.org To: Andrew Morton cc: Ingo Molnar , rlrevell@joe-job.com, linux-kernel@vger.kernel.org Subject: Re: [patch 0/3] j_state_lock, j_list_lock, remove-bitlocks In-Reply-To: <20050316024022.6d5c4706.akpm@osdl.org> Message-ID: References: <20050315120053.GA4686@elte.hu> <20050315133540.GB4686@elte.hu> <20050316085029.GA11414@elte.hu> <20050316011510.2a3bdfdb.akpm@osdl.org> <20050316095155.GA15080@elte.hu> <20050316020408.434cc620.akpm@osdl.org> <20050316101906.GA17328@elte.hu> <20050316024022.6d5c4706.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 27 On Wed, 16 Mar 2005, Andrew Morton wrote: > > Those two are in the journal, actually. You refer to jbd_lock_bh_state() > and jbd_lock_bh_journal_head(). I think they both need to be in the > buffer_head. jbd_lock_bh_journal_head() can probably go away (just use > caller's jbd_lock_bh_state()). > > Or make them global, or put them in the journal. The jbd_lock_bh_journal_head can be one global lock without a problem. But when I made jbd_lock_bh_state a global lock, I believe it deadlocked on me. So this one has to go into the buffer head. What do you mean with "put them in the journal", do you mean the journal_s structure? Is there a safe way to get to that structure from the buffer head? The state lock is used quite a bit and it gets tricky trying to figure out how to use other structures wrt buffer_heads at all the locations that use jbd_lock_bh_state. -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/