Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261438AbVCRFnY (ORCPT ); Fri, 18 Mar 2005 00:43:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261440AbVCRFnY (ORCPT ); Fri, 18 Mar 2005 00:43:24 -0500 Received: from rproxy.gmail.com ([64.233.170.200]:38211 "EHLO rproxy.gmail.com") by vger.kernel.org with ESMTP id S261438AbVCRFnS (ORCPT ); Fri, 18 Mar 2005 00:43:18 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=oorC7K55IzbnxfRvTFCBsluVguzNZHwJLkHzo+Pt0heyp3bh8EtjAB3LlzNTfE9wBfA3EZbdX2HSS15ndp9Tsl0B+OsoC5rMqa6lQmTrK4W7Zb4ko/7MqhY2bdC3x2snF047rusuWoSsbQTODw11Rk7i3APFhF+7hVoWy25qzRs= Message-ID: <29495f1d050317214315f6da3d@mail.gmail.com> Date: Thu, 17 Mar 2005 21:43:17 -0800 From: Nish Aravamudan Reply-To: Nish Aravamudan To: Christoph Lameter Subject: Re: [PATCH] Prezeroing V8 + free_hot_zeroed_page + free_cold_zeroed page Cc: Jason Uhlenkott , Andrew Morton , holt@sgi.com, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: <20050317140831.414b73bb.akpm@osdl.org> <20050318020645.GC156968@dragonfly.engr.sgi.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 29 On Thu, 17 Mar 2005 18:09:11 -0800 (PST), Christoph Lameter wrote: > On Thu, 17 Mar 2005, Jason Uhlenkott wrote: > > > On Thu, Mar 17, 2005 at 05:36:50PM -0800, Christoph Lameter wrote: > > > + while (avenrun[0] >= ((unsigned long)sysctl_scrub_load << FSHIFT)) { > > > + set_current_state(TASK_UNINTERRUPTIBLE); > > > + schedule_timeout(30*HZ); > > > + } > > > > This should probably be TASK_INTERRUPTIBLE. It'll never actually get > > interrupted either way since kernel threads block all signals, but > > sleeping uninterruptibly contributes to the load average. > > Correct. .... I just do not seem to be able to get this right. I think msleep_interruptible(30000) would be your best choice, then. Maybe with a comment that you don't actually expect signals, but are using TASK_INTERRUPTIBLE to avoid contributing to load average (that way, if the loadavg calculation changes someday, somebody will be able to change your sleep over appropriately). Thanks, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/