Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262388AbVCRXZQ (ORCPT ); Fri, 18 Mar 2005 18:25:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262098AbVCRXYn (ORCPT ); Fri, 18 Mar 2005 18:24:43 -0500 Received: from fire.osdl.org ([65.172.181.4]:6882 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262268AbVCRXUR (ORCPT ); Fri, 18 Mar 2005 18:20:17 -0500 Message-ID: <423B6218.6010602@osdl.org> Date: Fri, 18 Mar 2005 15:19:52 -0800 From: "Randy.Dunlap" Organization: OSDL User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Paul Mackerras CC: lkml , linux-mm@kvack.org, akpm@osdl.org, davem@davemloft.net, wli@holomorphy.com, riel@redhat.com, kurt@garloff.de, Keir.Fraser@cl.cam.ac.uk, Ian.Pratt@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk Subject: Re: [PATCH 1/4] io_remap_pfn_range: add for all arch-es References: <20050318112545.6f5f7635.rddunlap@osdl.org> <20050318113352.0baaaf5e.rddunlap@osdl.org> <16955.23669.792362.539790@cargo.ozlabs.ibm.com> In-Reply-To: <16955.23669.792362.539790@cargo.ozlabs.ibm.com> Content-Type: multipart/mixed; boundary="------------000408070900090309060601" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 52 This is a multi-part message in MIME format. --------------000408070900090309060601 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Paul Mackerras wrote: > > Just by inspection, this looks like pfn should be changed to > paddr64 >> PAGE_SHIFT in that last line. > > Paul. Agreed, thank you. Patch is attached. -- ~Randy --------------000408070900090309060601 Content-Type: text/x-patch; name="ioremap_ppc_shift.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ioremap_ppc_shift.patch" Fix asm-ppc argument, spotted by Paul Mackerras. Signed-off-by: Randy Dunlap diffstat:= include/asm-ppc/pgtable.h | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./include/asm-ppc/pgtable.h~ioremap_ppc_shift ./include/asm-ppc/pgtable.h --- ./include/asm-ppc/pgtable.h~ioremap_ppc_shift 2005-03-18 10:20:47.000000000 -0800 +++ ./include/asm-ppc/pgtable.h 2005-03-18 15:15:56.000000000 -0800 @@ -743,7 +743,7 @@ static inline int io_remap_pfn_range(str pgprot_t prot) { phys_addr_t paddr64 = fixup_bigphys_addr(pfn << PAGE_SHIFT, size); - return remap_pfn_range(vma, vaddr, pfn, size, prot); + return remap_pfn_range(vma, vaddr, paddr64 >> PAGE_SHIFT, size, prot); } #else #define io_remap_page_range(vma, vaddr, paddr, size, prot) \ --------------000408070900090309060601-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/