Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261214AbVCTNpk (ORCPT ); Sun, 20 Mar 2005 08:45:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261216AbVCTNpk (ORCPT ); Sun, 20 Mar 2005 08:45:40 -0500 Received: from wproxy.gmail.com ([64.233.184.203]:11218 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261214AbVCTNpg (ORCPT ); Sun, 20 Mar 2005 08:45:36 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding; b=gNB/zL6uIGOCNc9Yqe5uWK7cHtUY5e7sXJ+OFVXZ9Z/BIXHLBjjkF8Z2fIMW3MHxHXeD05QKxqk5hih1grYpjONTuM8TrCWp/Q6fhs+PUdSyRf+/0+U1A1vv7nOtRxiz0z3zrPiSdY+OG+irR7uz9z/twd6JgfB4LAylJTfZYm4= Message-ID: Date: Sun, 20 Mar 2005 14:45:36 +0100 From: Magnus Damm Reply-To: Magnus Damm To: linux-kernel@vger.kernel.org Subject: af_unix.c, KBUILD_MODNAME and unix Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 821 Lines: 21 Hello All, af_unix.c is currenty built with KBUILD_MODNAME=unix. This seems to work rather well today, but if someone actually tries to use KBUILD_MODNAME then they will end up with a preprocessor surprise: KBUILD_MODNAME -> unix -> 1, because "unix" is defined to 1. With other words, if someone adds module_param(foo,...) code to af_unix.c and compiles the code as built in then they will have to use "1.foo" to set the variable instead of "unix.foo" as expected. Solution? #undef unix? I came across this when trying to autogenerate parameter documentation... / magnus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/