Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261816AbVCUOzs (ORCPT ); Mon, 21 Mar 2005 09:55:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261818AbVCUOzs (ORCPT ); Mon, 21 Mar 2005 09:55:48 -0500 Received: from [81.2.110.250] ([81.2.110.250]:34514 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S261816AbVCUOzr (ORCPT ); Mon, 21 Mar 2005 09:55:47 -0500 Subject: Re: [PATCH] alpha build fixes From: Alan Cox To: Richard Henderson Cc: Jeff Garzik , Andrew Morton , Dave Jones , Greg KH , chas williams - CONTRACTOR , Leendert van Doorn , Reiner Sailer , Linux Kernel Mailing List In-Reply-To: <20050319231116.GA4114@twiddle.net> References: <423BABBF.6030103@pobox.com> <20050319231116.GA4114@twiddle.net> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1111416728.14833.20.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Mon, 21 Mar 2005 14:52:10 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 21 On Sad, 2005-03-19 at 23:11, Richard Henderson wrote: > On Fri, Mar 18, 2005 at 11:34:07PM -0500, Jeff Garzik wrote: > > +/* TODO: integrate with include/asm-generic/pci.h ? */ > > +static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) > > +{ > > + return channel ? 15 : 14; > > +} > > Am I missing something, or is this *only* used by drivers/ide/pci/amd74xx.c? > Why in the world would we have this much infrastructure for one driver? And > why not just not compile that one for Alpha, since it'll never be used. The issue is bigger - it's needed for the CMD controllers on PA-RISC for example it appears - and anything else where IDE legacy IRQ is wired oddly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/