Date: Mon, 21 Mar 2005 10:45:17 -0600
From: Nathan Lynch <ntl@pobox.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: akpm@osdl.org, paulus@samba.org, linux-kernel@vger.kernel.org,
       linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c
Message-ID: <20050321164517.GB16469@otto>
References: <200503211519.j2LFJ1os021884@harpo.it.uu.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503211519.j2LFJ1os021884@harpo.it.uu.se>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 25

On Mon, Mar 21, 2005 at 04:19:01PM +0100, Mikael Pettersson wrote:
> Compiling 2.6.12-rc1-mm1 for ppc64 fails with:
> 
> arch/ppc64/kernel/prom.c:1691: error: syntax error before 'prom_reconfig_notifier'
> arch/ppc64/kernel/prom.c:1692: error: field name not in record or union initializer
> arch/ppc64/kernel/prom.c:1692: error: (near initialization for 'prom_reconfig_nb')
> arch/ppc64/kernel/prom.c:1692: warning: initialization makes pointer from integer without a cast
> make[1]: *** [arch/ppc64/kernel/prom.o] Error 1
> make: *** [arch/ppc64/kernel] Error 2
> 
> Fix: repair the obvious syntax error (missing "=").

Thanks for the fix; the mistake was mine.  Lest Andrew and Paulus
think I'm sending untested patches, the compiler I'm using (gcc
3.3.3-hammer) does not give an error or even a warning.  Sorry for the
inconvenience; I'll have to upgrade to a less forgiving version of
gcc.


Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/