Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261264AbVCUR5d (ORCPT ); Mon, 21 Mar 2005 12:57:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261341AbVCUR5d (ORCPT ); Mon, 21 Mar 2005 12:57:33 -0500 Received: from ozlabs.org ([203.10.76.45]:5273 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S261264AbVCUR5Y (ORCPT ); Mon, 21 Mar 2005 12:57:24 -0500 Date: Tue, 22 Mar 2005 04:48:23 +1100 From: Anton Blanchard To: akpm@osdl.org, Mikael Pettersson Cc: paulus@samba.org, linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org Subject: [PATCH] ppc64: fix gcc4 compile error in paca.h Message-ID: <20050321174823.GC23908@krispykreme> References: <200503211518.j2LFIMP6021847@harpo.it.uu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503211518.j2LFIMP6021847@harpo.it.uu.se> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1456 Lines: 48 Thanks, looks good. Anton -- From: Mikael Pettersson Compiling 2.6.12-rc1 or 2.6.12-rc1-mm1 for ppc64 with gcc4 fails with: In file included from include/asm/spinlock.h:20, from include/linux/spinlock.h:43, from include/linux/signal.h:5, from arch/ppc64/kernel/asm-offsets.c:17: include/asm/paca.h:25: error: array type has incomplete element type make[1]: *** [arch/ppc64/kernel/asm-offsets.s] Error 1 make: *** [arch/ppc64/kernel/asm-offsets.s] Error 2 This is an array-of-incomplete-type error. Fix: move array decl to after the struct decl. Signed-off-by: Mikael Pettersson Signed-off-by: Anton Blanchard --- linux-2.6.12-rc1/include/asm-ppc64/paca.h.~1~ 2005-03-02 19:24:19.000000000 +0100 +++ linux-2.6.12-rc1/include/asm-ppc64/paca.h 2005-03-21 15:29:26.000000000 +0100 @@ -22,7 +22,6 @@ #include #include -extern struct paca_struct paca[]; register struct paca_struct *local_paca asm("r13"); #define get_paca() local_paca @@ -115,4 +114,6 @@ struct paca_struct { #endif }; +extern struct paca_struct paca[]; + #endif /* _PPC64_PACA_H */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/