Date: Mon, 21 Mar 2005 16:56:26 -0600
From: Nathan Lynch <ntl@pobox.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Mikael Pettersson <mikpe@csd.uu.se>, akpm@osdl.org,
       linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c
Message-ID: <20050321225626.GD16469@otto>
References: <200503211519.j2LFJ1os021884@harpo.it.uu.se> <16959.17091.901784.666693@cargo.ozlabs.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16959.17091.901784.666693@cargo.ozlabs.ibm.com>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1049
Lines: 26

On Tue, Mar 22, 2005 at 08:55:15AM +1100, Paul Mackerras wrote:
> Mikael Pettersson writes:
> 
> > Compiling 2.6.12-rc1-mm1 for ppc64 fails with:
> > 
> > arch/ppc64/kernel/prom.c:1691: error: syntax error before 'prom_reconfig_notifier'
> 
> Currently prom.c is in a mess because Linus applied the last 2 of 8
> patches from Nathan Lynch but not the first 6.  :-P

Actually, this one is my fault, although unless I'm really missing
something gcc 3.4.2 silently accepts the invalid syntax.

All eight of the patches from the pSeries reconfig series are present
in 2.6.12-rc1-mm1.  The error Mikael reported is unrelated to the
state of Linus' tree, and his patch is correct.  (The mistake is
present in both versions of the patches which I posted for review on
linuxppc64-dev; nobody caught it.)


Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/