Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262543AbVCVIGh (ORCPT ); Tue, 22 Mar 2005 03:06:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262545AbVCVIGg (ORCPT ); Tue, 22 Mar 2005 03:06:36 -0500 Received: from wproxy.gmail.com ([64.233.184.202]:22518 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S262543AbVCVIG3 (ORCPT ); Tue, 22 Mar 2005 03:06:29 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=lGBmNZtEtYGZxE0ezohNGnFzQovSbj/i/FI8Ww9ZZsVob2pzHYWKUWvtrfvbvcsezjzYCKHESMNNC9NAqnuO3zvTpAct/QUB/KLAJjl+ENu/45VdXTD4ETo6der7gOOU5ENnkuJxpIBMMM1PbysFe4no3re1yz38zWlbnTw2yg8= Message-ID: Date: Tue, 22 Mar 2005 09:06:29 +0100 From: Magnus Damm Reply-To: Magnus Damm To: Johannes Stezenbach , Magnus Damm , linux-kernel@vger.kernel.org Subject: Re: [PATCH] dvb_frontend: MODULE_PARM_DESC In-Reply-To: <20050322025104.GA18067@linuxtv.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: <20050321154226.19053.36781.35540@clementine.local> <20050322025104.GA18067@linuxtv.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 36 On Tue, 22 Mar 2005 03:51:04 +0100, Johannes Stezenbach wrote: > On Mon, Mar 21, 2005 at 05:10:27PM +0100, Magnus Damm wrote: > > Remove "dvb_"-prefix from parameters. Without the patch all parameters except > > the declaration of parameter "frontend_debug" have a "dvb_"-prefix. > > Why is that dvb_ prefix a problem? It is no biggie and probably not worth breaking users' configuration like you said, but most drivers do not have their KBUILD_MODNAME included in the parameter names. Setting parameters that have KBUILD_MODNAME as prefix from the kernel commandline is then done by KBUILD_MODNAME.KBUILD_MODNAME_xxx and that is plain ugly - especially when a list of parameters are generated from the source. Some bad citizens IMO: dvb.dvb_shutdown_timeout, asus.asus_gid, arlan.arlan_entry_debug > > Error detected with section2text.rb, see autoparam patch. > > Please only fix errors and do not rename other parameters. We shouldn't > break users' modprobe.conf option settings. Ok, just fixing errors: frontend_debug should be renamed to dvb_frontend_debug or the parameter description should at least match the parameter... Thanks, / magnus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/