Date: Tue, 22 Mar 2005 12:01:26 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Len Brown <len.brown@intel.com>
Cc: Shaohua Li <shaohua.li@intel.com>, Andrew Morton <akpm@osdl.org>,
       rjw@sisk.pl, lkml <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.12-rc1-mm1: Kernel BUG at pci:389
Message-ID: <20050322110126.GB1780@elf.ucw.cz>
References: <20050322013535.GA1421@elf.ucw.cz> <1111461253.18927.15.camel@sli10-desk.sh.intel.com> <1111464268.17329.27.camel@d845pe>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1111464268.17329.27.camel@d845pe>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1054
Lines: 33

Hi!

> Will this do it for the moment?

Its certainly better.

What about

> > > +static int acpi_pci_set_power_state(struct pci_dev *dev,
> > pci_power_t state)
> > > +{
> > > +     acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
> > > +     static int state_conv[] = {
> > > +             [0] = 0,
> > > +             [1] = 1,
> > > +             [2] = 2,
> > > +             [3] = 3,
> > > +             [4] = 3
> > > +     };
> > > +     int acpi_state = state_conv[(int __force) state];

...this force? Then platform_pci_choose_state should not be NULL by
default and acpi_pci_choose_state should really have some more
reasonable calling convention.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/