Subject: Re: [patch 1/4 with proper signed-off]
	security/selinux/ss/policydb.c: fix sparse warnings
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Domen Puncer <domen@coderock.org>
Cc: jmorris@redhat.com, linux-kernel@vger.kernel.org, adobriyan@mail.ru
In-Reply-To: <1111504775.15346.88.camel@moss-spartans.epoch.ncsc.mil>
References: <20050319131938.E04781ECA8@trashy.coderock.org>
	 <20050320115916.GT14273@nd47.coderock.org>
	 <1111504775.15346.88.camel@moss-spartans.epoch.ncsc.mil>
Content-Type: text/plain
Organization: National Security Agency
Date: Tue, 22 Mar 2005 10:59:21 -0500
Message-Id: <1111507161.15346.116.camel@moss-spartans.epoch.ncsc.mil>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 23

On Tue, 2005-03-22 at 10:19 -0500, Stephen Smalley wrote:
> You didn't remove the loop that already converted these values to little

s/ to / from /

> endian already (no that isn't the same as the earlier loop that you did
> remove), so now you are converting them twice.  And why is this new code
> better even if you fix this omission?  

Note btw that you would also need to modify usage of buf[0] and buf[1]
if you do remove that loop.  But I'm still not clear on the benefit of
the change (silencing warnings generated by a checker doesn't count
unless they point to a real bug).

-- 
Stephen Smalley <sds@tycho.nsa.gov>
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/