Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261539AbVCWLcf (ORCPT ); Wed, 23 Mar 2005 06:32:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261540AbVCWLcf (ORCPT ); Wed, 23 Mar 2005 06:32:35 -0500 Received: from arnor.apana.org.au ([203.14.152.115]:60427 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S261539AbVCWLcd (ORCPT ); Wed, 23 Mar 2005 06:32:33 -0500 From: Herbert Xu To: yxie@cs.stanford.edu (Yichen Xie) Subject: Re: memory leak in net/sched/ipt.c? Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, davem@davemloft.net, kaber@trash.net, hadi@cyberus.ca Organization: Core In-Reply-To: X-Newsgroups: apana.lists.os.linux.kernel User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Wed, 23 Mar 2005 22:30:49 +1100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 38 Yichen Xie wrote: > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump > is called? It seems to be. This patch should free it. Signed-off-by: Herbert Xu BTW, please report networking bugs to netdev@oss.sgi.com. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- ===== net/sched/ipt.c 1.14 vs edited ===== --- 1.14/net/sched/ipt.c 2005-02-07 16:39:40 +11:00 +++ edited/net/sched/ipt.c 2005-03-23 22:28:13 +11:00 @@ -284,10 +284,12 @@ tm.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse); tm.expires = jiffies_to_clock_t(p->tm.expires); RTA_PUT(skb, TCA_IPT_TM, sizeof (tm), &tm); + kfree(t); return skb->len; rtattr_failure: skb_trim(skb, b - skb->data); + kfree(t); return -1; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/