Subject: Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jens Axboe <axboe@suse.de>, SCSI Mailing List <linux-scsi@vger.kernel.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <4240F5A9.80205@gmail.com>
References: <20050323021335.960F95F8@htj.dyndns.org>
	 <20050323021335.4682C732@htj.dyndns.org>
	 <1111550882.5520.93.camel@mulgrave>  <4240F5A9.80205@gmail.com>
Content-Type: text/plain
Date: Wed, 23 Mar 2005 09:12:16 -0600
Message-Id: <1111590736.5441.10.camel@mulgrave>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 980
Lines: 25

On Wed, 2005-03-23 at 13:50 +0900, Tejun Heo wrote:
>   Well, but it's because scsi midlayer calls back into usb-storage eh 
> after the detaching process is complete.

Yes, but that's legitimate.  It's always been explicitly stated that we
can't ensure absolute synchronisation in the stack:  storage devices
must expect to have to reject I/O for devices they think have been
removed.

> > However, the current host code does need fixing, but the fix is to move
> > it over to a proper state model rather than the current bit twiddling we
> > do.
> 
>   I agree & am working on it.  This patch was mainly to verify Jens' oops.

Thanks!  You can look at the device state model as a guide ...
originally that was a bit mask too.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/