Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262174AbVCXBKv (ORCPT ); Wed, 23 Mar 2005 20:10:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262296AbVCXBKv (ORCPT ); Wed, 23 Mar 2005 20:10:51 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:35600 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S262174AbVCXBKq (ORCPT ); Wed, 23 Mar 2005 20:10:46 -0500 Date: Thu, 24 Mar 2005 02:10:43 +0100 From: Adrian Bunk To: linux-kernel@vger.kernel.org Subject: [2.6 patch] fs/attr.c: fix check after use Message-ID: <20050324011043.GI1948@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 30 This patch fixes a check after use found by the Coverity checker. Signed-off-by: Adrian Bunk --- linux-2.6.12-rc1-mm1-full/fs/attr.c.old 2005-03-23 04:44:40.000000000 +0100 +++ linux-2.6.12-rc1-mm1-full/fs/attr.c 2005-03-23 04:45:40.000000000 +0100 @@ -112,7 +112,7 @@ int notify_change(struct dentry * dentry, struct iattr * attr) { struct inode *inode = dentry->d_inode; - mode_t mode = inode->i_mode; + mode_t mode; int error; struct timespec now = current_fs_time(inode->i_sb); unsigned int ia_valid = attr->ia_valid; @@ -120,6 +120,8 @@ if (!inode) BUG(); + mode = inode->i_mode; + attr->ia_ctime = now; if (!(ia_valid & ATTR_ATIME_SET)) attr->ia_atime = now; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/