Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261969AbVCXDki (ORCPT ); Wed, 23 Mar 2005 22:40:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263008AbVCXDjL (ORCPT ); Wed, 23 Mar 2005 22:39:11 -0500 Received: from graphe.net ([209.204.138.32]:10762 "EHLO graphe.net") by vger.kernel.org with ESMTP id S262536AbVCXDh0 (ORCPT ); Wed, 23 Mar 2005 22:37:26 -0500 Date: Wed, 23 Mar 2005 19:37:14 -0800 (PST) From: Christoph Lameter X-X-Sender: christoph@server.graphe.net To: Adrian Bunk cc: Andrew Morton , Tina Yang , Scott Bardone , linux-kernel@vger.kernel.org, jgarzik@pobox.com, linux-net@vger.kernel.org Subject: Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups In-Reply-To: <20050324031026.GV1948@stusta.de> Message-ID: References: <20050321025159.1cabd62e.akpm@osdl.org> <20050324031026.GV1948@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.9 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1085 Lines: 34 We just send an update to Andrew and Jeff that also fixes this issue. Sadly that patch is >300k so we cannot post it to the list. On Thu, 24 Mar 2005, Adrian Bunk wrote: > The #define MODVERSIONS doesn't make sense. > > And there's no need to #ifdef an #include . > > Signed-off-by: Adrian Bunk > > --- linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h.old 2005-03-24 01:20:02.000000000 +0100 > +++ linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h 2005-03-24 01:20:17.000000000 +0100 > @@ -33,13 +33,7 @@ > #define __CHELSIO_OSDEP_H > > #include > -#if defined(MODULE) && ! defined(MODVERSIONS) > -#define MODVERSIONS > -#endif > -#ifdef MODULE > #include > -#endif > - > #include > #include > #include > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/