Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263065AbVCXH2R (ORCPT ); Thu, 24 Mar 2005 02:28:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263075AbVCXH2Q (ORCPT ); Thu, 24 Mar 2005 02:28:16 -0500 Received: from mail.kroah.org ([69.55.234.183]:52354 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S263065AbVCXH2G (ORCPT ); Thu, 24 Mar 2005 02:28:06 -0500 Date: Wed, 23 Mar 2005 23:24:13 -0800 From: Greg KH To: Valdis.Kletnieks@vt.edu Cc: Frank Sorenson , Dmitry Torokhov , LKML Subject: Re: [PATCH 0/5] I8K driver facelift Message-ID: <20050324072413.GK10604@kroah.com> References: <200502240110.16521.dtor_core@ameritech.net> <4233B65A.4030302@tuxrocks.com> <4238A76A.3040408@tuxrocks.com> <200503170816.j2H8GOEV004208@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200503170816.j2H8GOEV004208@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 43 On Thu, Mar 17, 2005 at 03:16:24AM -0500, Valdis.Kletnieks@vt.edu wrote: > On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > and store functions also accept the name of the attribute as a parameter. > > This lets the functions know what attribute is being accessed, and allows > > us to create attributes that share show and store functions, so things > > don't need to be defined at compile time (I feel slightly evil!). > > > > This patch puts the correct number of temp sensors and fans into sysfs, > > and only exposes power_status if enabled by the power_status module > > parameter. > > Works for me: > > [/sys/bus/platform/drivers/i8k/i8k]2 ls -l > total 0 > lrwxrwxrwx 1 root root 0 Mar 17 03:02 bus -> ../../../bus/platform > -r--r--r-- 1 root root 4096 Mar 17 03:02 cpu_temp > -rw-r--r-- 1 root root 4096 Mar 17 03:01 detach_state > lrwxrwxrwx 1 root root 0 Mar 17 03:02 driver -> ../../../bus/platform/drivers/i8k > -r--r--r-- 1 root root 4096 Mar 17 03:02 fan1_speed > -rw-r--r-- 1 root root 4096 Mar 17 03:02 fan1_state > -r--r--r-- 1 root root 4096 Mar 17 03:02 fan2_speed > -rw-r--r-- 1 root root 4096 Mar 17 03:02 fan2_state > drwxr-xr-x 2 root root 0 Mar 17 03:02 power > -r--r--r-- 1 root root 4096 Mar 17 03:02 power_status > -r--r--r-- 1 root root 4096 Mar 17 03:02 temp1 > -r--r--r-- 1 root root 4096 Mar 17 03:02 temp2 > > The valyes of the fan* settings, and cpu_temp match what's reported in /proc/i8k. Please match the same units and filename as the other i2c sensors. See the documentation in the Documentation/i2c/ directory for what that standard is, so userspace programs will "just work" with your devices. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/