Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261743AbVCYSjP (ORCPT ); Fri, 25 Mar 2005 13:39:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261744AbVCYSiv (ORCPT ); Fri, 25 Mar 2005 13:38:51 -0500 Received: from jade.aracnet.com ([216.99.193.136]:48555 "EHLO jade.spiritone.com") by vger.kernel.org with ESMTP id S261743AbVCYSic (ORCPT ); Fri, 25 Mar 2005 13:38:32 -0500 Date: Fri, 25 Mar 2005 10:38:04 -0800 From: "Martin J. Bligh" To: Dave Hansen , akpm@osdl.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andy Whitcroft Subject: Re: [PATCH] remove non-DISCONTIG use of pgdat->node_mem_map Message-ID: <22520000.1111775883@[10.10.2.4]> In-Reply-To: References: X-Mailer: Mulberry/2.2.1 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 29 > This patch effectively eliminates direct use of pgdat->node_mem_map > outside of the DISCONTIG code. On a flat memory system, these fields > aren't currently used, neither are they on a sparsemem system. > > There was also a node_mem_map(nid) macro on many architectures. Its > use along with the use of ->node_mem_map itself was not consistent. > It has been removed in favor of two new, more explicit, > arch-independent macros: > > pgdat_page_nr(pgdat, pagenr) > nid_page_nr(nid, pagenr) > > I called them "pgdat" and "nid" because we overload the term "node" > to mean "NUMA node", "DISCONTIG node" or "pg_data_t" in very > confusing ways. I believe the newer names are much clearer. Seems like a good plan - the abstraction will make it easier to change the underlying mechanism. I'm not desperately keen on the new naming, but given the current code state it makes sense, I guess. Once Andy has got sparsemem merged up, and we change struct pgdat to be called struct node or something more sensible, we can revisit it then. Signed-off-by: Martin J. Bligh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/