Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261657AbVC0OAE (ORCPT ); Sun, 27 Mar 2005 09:00:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261660AbVC0OAE (ORCPT ); Sun, 27 Mar 2005 09:00:04 -0500 Received: from wproxy.gmail.com ([64.233.184.194]:48567 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261657AbVC0OAB (ORCPT ); Sun, 27 Mar 2005 09:00:01 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=Z/FHdZXOKE3yRoTCJuoacrr+1rlm3R9+GDXHfVBrPyRnq0nG1XNRz7eh5fAbCBAEvKIYFnbdyNk9oPtfkbfWzU1G9SAK+QaLlwb3osIGGkc/uEkp07izbj6a31WWVMuZMOPxRygJp1hXblXVEW9XOtEADapq4mS86ZD5cAtDvbc= Message-ID: <84144f02050327060051b61e54@mail.gmail.com> Date: Sun, 27 Mar 2005 17:00:01 +0300 From: Pekka Enberg Reply-To: Pekka Enberg To: linux-os@analogic.com Subject: Re: [PATCH] remove redundant NULL pointer checks prior to calling kfree() in fs/nfsd/ Cc: Jesper Juhl , Neil Brown , nfs@lists.sourceforge.net, Trond Myklebust , linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 620 Lines: 14 On Fri, 25 Mar 2005 17:34:29 -0500 (EST), linux-os wrote: > You really should reconsider this activity. It is quite counter-productive. No it's not. NULL is checked twice without Jesper's cleanups. If kfree() calls are really that performance sensitive, just make it inline and GCC will take care of it. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/