Message-ID: <4247F2AA.7070201@ens-lyon.org>
Date: Mon, 28 Mar 2005 14:03:54 +0200
From: Brice Goglin <Brice.Goglin@ens-lyon.org>
User-Agent: Mozilla Thunderbird 1.0 (X11/20050116)
MIME-Version: 1.0
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radeonfb: Fix mode setting on CRT monitors
References: <1111969496.5409.40.camel@gaston>
In-Reply-To: <1111969496.5409.40.camel@gaston>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 957
Lines: 24

Benjamin Herrenschmidt a ?crit :
> Hi !
> 
> Current radeonfb is a bit "anal" about accepting CRT modes, it basically only
> accepts modes that have the exact resolution, which tends to break with fbcon
> on console switches as it provides "approximate" modes. This patch fixes it
> by having the driver chose the closest possible mode instead of looking for
> an exact match.

Hi Benjamin,

I tried your patch because on recent -mm kernels I see dirty colored 
columns during a few seconds when switching from X to radeon fbcon
(looks like remaining colors of X).
I don't know what visible effect your patch is supposed to have.
I didn't see any difference, but I doesn't seem to break anything.

Regards,
Brice
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/