Subject: Re: [PATCH] kernel/param.c: don't use .max when .num is NULL in
	param_array_set()
From: Rusty Russell <rusty@rustcorp.com.au>
To: Bert Wesarg <wesarg@informatik.uni-halle.de>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <Pine.GSO.4.56.0503271455190.25037@turing>
References: <Pine.GSO.4.56.0503271455190.25037@turing>
Content-Type: text/plain
Date: Tue, 29 Mar 2005 16:05:53 +1000
Message-Id: <1112076353.21459.34.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 29

On Sun, 2005-03-27 at 14:57 +0200, Bert Wesarg wrote:
> Hello,
> 
> there seems to be a bug, at least for me, in kernel/param.c for arrays
> with .num == NULL. If .num == NULL, the function param_array_set() uses
> &.max for the call to param_array(), wich alters the .max value to the
> number of arguments. The result is, you can't set more array arguments as
> the last time you set the parameter.

Yes.  But this ignores the larger problem, in that the printing routines
need *some* way of telling how many to print.  We could add a new
element for this case, at the price of enlarging the structure a little
for every array parameter.  I think you'll find that with your patch,
the code does this:

	$ insmod example.ko array=1,2,3
	$ cat /sys/module/example/parameters/array
	1,2,3,0,0,0,0,0,0,0

Cheers,
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/