DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
        b=oHf8NWLKiYBVKZd6wANIzeO7JCOGx+90qjqDZtsK+7V6fI4EhuafemkYSrCVYrqudX7ArGQPzSuaYp9ECb8f39C6oejrrabe8wwLmMYC308HCdCJ0OX6SO/+iGXIcr9zlgLY34RrM5o5HY6euVO2W0HMrRgoSHivEPAmeQ7IysU=
Message-ID: <d120d50005032911114fd2ea32@mail.gmail.com>
Date: Tue, 29 Mar 2005 14:11:30 -0500
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reply-To: dtor_core@ameritech.net
To: Pavel Machek <pavel@suse.cz>
Subject: Re: swsusp 'disk' fails in bk-current - intel_agp at fault?
Cc: Stefan Seyfried <seife@suse.de>, Andy Isaacson <adi@hexapodia.org>,
       kernel list <linux-kernel@vger.kernel.org>,
       Vojtech Pavlik <vojtech@suse.cz>
In-Reply-To: <20050329181831.GB8125@elf.ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
References: <20050323184919.GA23486@hexapodia.org> <4242CE43.1020806@suse.de>
	 <20050324181059.GA18490@hexapodia.org> <4243252D.6090206@suse.de>
	 <20050324235439.GA27902@hexapodia.org> <4243D854.2010506@suse.de>
	 <d120d50005032908183b2f622e@mail.gmail.com>
	 <20050329181831.GB8125@elf.ucw.cz>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 28

On Tue, 29 Mar 2005 20:18:31 +0200, Pavel Machek <pavel@suse.cz> wrote:
> Hi!
> 
> > If you look at Andy's second trace you will see that we are waiting
> > for the disk I/O to get /sbin/hotplug from the disk. Pavel, do you
> > know why IO does not complete? khelper is a kernel thread so it is
> > marked with
> > PF_NOFREEZE. Could it be that we managed to freeze kblockd?
> 
> Uf, no idea about kblockd freezing -- we certainly should not.
> 
> *But*, if we are doing execve while system is frozen, something is
> very wrong. We should not be doing execve in the first place.

Well, there lies a problem - some devices have to do execve because
they need firmware to operate. Also, again, some buses with
hot-pluggable devices will attempt to clean up unsuccessful resume and
this will cause hotplug events. The point is you either resume system
or you don't. We probably need a separate "unfreeze" callback,
although this is kind of messy.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/