Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261477AbVC2VYx (ORCPT ); Tue, 29 Mar 2005 16:24:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261467AbVC2VWK (ORCPT ); Tue, 29 Mar 2005 16:22:10 -0500 Received: from mx1.redhat.com ([66.187.233.31]:19850 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261252AbVC2VRt (ORCPT ); Tue, 29 Mar 2005 16:17:49 -0500 Date: Tue, 29 Mar 2005 16:17:41 -0500 From: Neil Horman To: jamal Cc: Neil Horman , linux-kernel@vger.kernel.org, "David S. Miller" , netdev Subject: Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set Message-ID: <20050329211741.GL22447@hmsendeavour.rdu.redhat.com> References: <20050329202506.GI22447@hmsendeavour.rdu.redhat.com> <1112130720.1076.112.camel@jzny.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1112130720.1076.112.camel@jzny.localdomain> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 44 On Tue, Mar 29, 2005 at 04:12:01PM -0500, jamal wrote: > > This is being discussed on netdev at the moment. Thomas Graf is working > on a patch. > Thanks for the effort though. > > cheers, > jamal > No worries. What exactly is the point of contention on netdev? (I'm not currently following that list). My patch seems to follow the common practice for CONFIG_NET_CLS_ACT, in that all references to the action member of the appropriate struct are themselves ifdef-ed. Regards, Neil > On Tue, 2005-03-29 at 15:25, Neil Horman wrote: > > Patch to fix build break that occurs when CONFIG_NET_CLS_ACT is not set. > > > > Signed-off-by: Neil Horman > > > > cls_fw.c | 3 ++- > > cls_route.c | 3 ++- > > cls_tcindex.c | 3 ++- > > cls_u32.c | 2 ++ > > 4 files changed, 8 insertions(+), 3 deletions(-) > > > > -- /*************************************************** *Neil Horman *Software Engineer *Red Hat, Inc. *nhorman@redhat.com *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***************************************************/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/