Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261864AbVC3LPA (ORCPT ); Wed, 30 Mar 2005 06:15:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261863AbVC3LPA (ORCPT ); Wed, 30 Mar 2005 06:15:00 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:44730 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261862AbVC3LO6 (ORCPT ); Wed, 30 Mar 2005 06:14:58 -0500 Date: Wed, 30 Mar 2005 12:14:39 +0100 From: Christoph Hellwig To: Christoph Lameter Cc: Manfred Spraul , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mm@kvack.org, shai@scalex86.org Subject: Re: [PATCH] Pageset Localization V2 Message-ID: <20050330111439.GA13110@infradead.org> Mail-Followup-To: Christoph Hellwig , Christoph Lameter , Manfred Spraul , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mm@kvack.org, shai@scalex86.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 17 > +#define MAKE_LIST(list, nlist) \ > + do { \ > + if(list_empty(&list)) \ > + INIT_LIST_HEAD(nlist); \ > + else { nlist->next->prev = nlist; \ > + nlist->prev->next = nlist; \ > + } \ > + }while(0) This is horrible. Where are the nlist pointers supposed to point to? What's so magic you need the INIT_LIST_HEAD only conditionally? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/