Date: Wed, 30 Mar 2005 14:40:49 +0100
From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Lameter <christoph@lameter.com>
Cc: Manfred Spraul <manfred@colorfullife.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
       linux-mm@kvack.org, shai@scalex86.org
Subject: Re: [PATCH] Pageset Localization V2
Message-ID: <20050330134049.GA21986@parcelfarce.linux.theplanet.co.uk>
References: <Pine.LNX.4.58.0503292147200.32571@server.graphe.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0503292147200.32571@server.graphe.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 903
Lines: 18

On Tue, Mar 29, 2005 at 09:51:08PM -0800, Christoph Lameter wrote:
> +	BUG_ON(process_zones(smp_processor_id()));

No.  Who told you this was a good idea?  This is the *worst* kind of
assert, calling a function with side-effects.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/