Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261476AbVCaOcy (ORCPT ); Thu, 31 Mar 2005 09:32:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261473AbVCaOcy (ORCPT ); Thu, 31 Mar 2005 09:32:54 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:13032 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261469AbVCaOcq (ORCPT ); Thu, 31 Mar 2005 09:32:46 -0500 Date: Thu, 31 Mar 2005 15:32:35 +0100 From: Christoph Hellwig To: shobhit dayal Cc: hch@infradead.org, christoph@lameter.com, manfred@colorfullife.com, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mm@kvack.org, Shai Fultheim Subject: Re: Fwd: [PATCH] Pageset Localization V2 Message-ID: <20050331143235.GA18058@infradead.org> Mail-Followup-To: Christoph Hellwig , shobhit dayal , christoph@lameter.com, manfred@colorfullife.com, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mm@kvack.org, Shai Fultheim References: <20050330111439.GA13110@infradead.org> <1112187977.9773.15.camel@kuber> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1112187977.9773.15.camel@kuber> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 20 On Wed, Mar 30, 2005 at 06:36:18PM +0530, shobhit dayal wrote: > The goal here is to replace the head of a existing list pointed to by > 'list' with a new head pointed to by 'nlist'. > First there is a memcpy that copies the contents of list to nlist then > this macro is called. > The macro makes sure that if the old head was empty then INIT_LIST_HEAD > the 'nlist', if not then make sure that the nodes before and after the > head now correclty point to nlist instead of list. Which would be much nicer done using INIT_LIST_HEAD on the new head always and then calling list_replace (of which currently only a _rcu variant exists). Note to Christoph: Just duplicating the code doesn't make it better ;-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/