Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261482AbVCaOzg (ORCPT ); Thu, 31 Mar 2005 09:55:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261488AbVCaOzg (ORCPT ); Thu, 31 Mar 2005 09:55:36 -0500 Received: from mx2.elte.hu ([157.181.151.9]:44480 "EHLO mx2.elte.hu") by vger.kernel.org with ESMTP id S261482AbVCaOzL (ORCPT ); Thu, 31 Mar 2005 09:55:11 -0500 Date: Thu, 31 Mar 2005 16:54:39 +0200 From: Ingo Molnar To: Trond Myklebust Cc: Andrew Morton , rlrevell@joe-job.com, linux-kernel@vger.kernel.org Subject: Re: NFS client latencies Message-ID: <20050331145439.GA4896@elte.hu> References: <1112237239.26732.8.camel@mindpipe> <1112240918.10975.4.camel@lade.trondhjem.org> <20050331065942.GA14952@elte.hu> <20050330231801.129b0715.akpm@osdl.org> <20050331073017.GA16577@elte.hu> <1112270304.10975.41.camel@lade.trondhjem.org> <1112272451.10975.72.camel@lade.trondhjem.org> <20050331135825.GA2214@elte.hu> <1112279522.20211.8.camel@lade.trondhjem.org> <20050331143930.GA4032@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050331143930.GA4032@elte.hu> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 21 * Ingo Molnar wrote: > [...] To break the latency, can i just do a simple lock-break, via the > patch below? i think it's incorrect in its current form, because 'pos' is not necessarily safe and might be removed from the commit_list? the whole loop could be a "while (!list_empty(head))" thing, if it wasnt for the possibility for an nfs_set_page_writeback_locked() to skip an entry. Maybe a local list of 'already processed' requests should be built, and once the main list is emptied, moved back into the main list? Then the lock-break could be moved to the end of the loop. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/