Date: Fri, 1 Apr 2005 15:07:13 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
       Christoph Lameter <christoph@lameter.com>,
       "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC][PATCH] timers fixes/improvements
Message-ID: <20050401130713.GA3802@elte.hu>
References: <424D373F.1BCBF2AC@tv-sign.ru> <424D37B2.2CE24C67@tv-sign.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <424D37B2.2CE24C67@tv-sign.ru>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 806
Lines: 32


* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> struct timer_list {
> 	...
> 	timer_base_t *_base;
> };

namespace cleanliness: i'd suggest s/_base/base.

another detail:

> int __mod_timer(struct timer_list *timer, unsigned long expires)
[...]
> 		/* Ensure the timer is serialized. */
> 		if (base != &new_base->t_base
> 			&& base->running_timer == timer)
> 			goto unlock;

> unlock:
> 		spin_unlock_irqrestore(&base->lock, flags);
> 	} while (ret < 0);

so we keep looping in __mod_timer() when the timer is running? Couldnt 
this be a performance hit?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/