Date: Fri, 1 Apr 2005 17:20:22 -0800
From: Andrew Morton <akpm@osdl.org>
To: Daniel McNeil <daniel@osdl.org>
Cc: pbadari@us.ibm.com, sebastien.dugue@bull.net, jean-pierre.dion@bull.net,
       gh@us.ibm.com, janetmor@us.ibm.com, linux-kernel@vger.kernel.org,
       linux-aio@kvack.org
Subject: Re: [PATCH] Direct IO async short read bug followup
Message-Id: <20050401172022.45d0cdd5.akpm@osdl.org>
In-Reply-To: <1112404259.29841.19.camel@ibm-c.pdx.osdl.net>
References: <1111743607.1299.85.camel@frecb000686>
	<20050325014307.4395012e.akpm@osdl.org>
	<1111745400.1299.89.camel@frecb000686>
	<20050325022416.01c2535b.akpm@osdl.org>
	<42442743.40600@us.ibm.com>
	<1112404259.29841.19.camel@ibm-c.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 27

Daniel McNeil <daniel@osdl.org> wrote:
>
> I updated the patch to add an i_size element to the dio structure and
>  sample i_size during i/o submission.  When i/o completes the result can
>  be truncated to match the file size without using i_size_read(), thus
>  the aio result now matches the number of bytes read to the end of file.
> 

Can you provide the analysis of the bug, please?

> 
>  Daniel
> 
>  --- linux-2.6.11.orig/fs/direct-io.c	2005-04-01 15:33:11.000000000 -0800
>  +++ linux-2.6.11/fs/direct-io.c	2005-03-31 16:59:15.000000000 -0800
>  @@ -66,6 +66,7 @@ struct dio {
>   	struct bio *bio;		/* bio under assembly */
>   	struct inode *inode;
>   	int rw;
>  +	ssize_t i_size;			/* i_size when submitted */

I'll change this to loff_t, OK?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/