Date: Sat, 2 Apr 2005 11:26:54 -0800
From: Andrew Morton <akpm@osdl.org>
To: Rolf Eike Beer <eike-hotplug@sf-tec.de>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] PCI Hotplug: remove code duplication in
 drivers/pci/hotplug/ibmphp_pci.c
Message-Id: <20050402112654.3b12a3a5.akpm@osdl.org>
In-Reply-To: <200504021420.16772@bilbo.math.uni-mannheim.de>
References: <1112399271636@kroah.com>
	<200504021420.16772@bilbo.math.uni-mannheim.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1219
Lines: 29

Rolf Eike Beer <eike-hotplug@sf-tec.de> wrote:
>
> Greg KH wrote:
> > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, eike-hotplug@sf-tec.de
> >
> > [PATCH] PCI Hotplug: remove code duplication in
> > drivers/pci/hotplug/ibmphp_pci.c
> >
> > This patch removes some code duplication where if and else have the
> > same code at the beginning and the end of the branch.
> 
> Greg, as you correctly pointed out this patch if broken. It could never reach 
> the if branch and always uses the else branch. Please drop this one and 
> review the patch I sent on March 21th to pcihp-discuss for inclusion. It 
> removes much more duplication and handles this case correctly. Sorry, it 
> looks like I forgot to CC you. I'll bounce this mail to you.
> 

It's merged now, so sending a new patch which fixes that file up might be
simpler and less error-prone.

Latest ibmphp_pci.c causes gcc-2.95.4 to go into an infinite loop,
consuming 750MB of memory, which is a bit irritating.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/