Message-ID: <42507645.6010808@osvik.no>
Date: Mon, 04 Apr 2005 01:03:33 +0200
From: Dag Arne Osvik <da@osvik.no>
User-Agent: Mozilla Thunderbird 1.0.2-1.3.2 (X11/20050324)
MIME-Version: 1.0
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
CC: Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: Re: Use of C99 int types
References: <424FD9BB.7040100@osvik.no> <20050403220508.712e14ec.sfr@canb.auug.org.au> <424FE1D3.9010805@osvik.no> <20050403181318.GW8859@parcelfarce.linux.theplanet.co.uk>
In-Reply-To: <20050403181318.GW8859@parcelfarce.linux.theplanet.co.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1154
Lines: 36

Al Viro wrote:

>On Sun, Apr 03, 2005 at 02:30:11PM +0200, Dag Arne Osvik wrote:
>  
>
>>Yes, but wouldn't it be much better to avoid code like the following, 
>>which may also be wrong (in terms of speed)?
>>
>>#ifdef CONFIG_64BIT  // or maybe CONFIG_X86_64?
>> #define fast_u32 u64
>>#else
>> #define fast_u32 u32
>>#endif
>>    
>>
>
>... and with such name 99% will assume (at least at the first reading)
>that it _is_ 32bits.  We have more than enough portability bugs as it
>is, no need to invite more by bad names.
>  
>

Agreed.  The way I see it there are two reasonable options.  One is to 
just use u32, which is always correct but sacrifices speed (at least 
with the current gcc).  The other is to introduce C99 types, which Linus 
doesn't seem to object to when they are kept away from interfaces 
(http://infocenter.guardiandigital.com/archive/linux-kernel/2004/Dec/0117.html).

-- 
  Dag Arne

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/