Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261464AbVDEBJI (ORCPT ); Mon, 4 Apr 2005 21:09:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261494AbVDEBJI (ORCPT ); Mon, 4 Apr 2005 21:09:08 -0400 Received: from fmr19.intel.com ([134.134.136.18]:680 "EHLO orsfmr004.jf.intel.com") by vger.kernel.org with ESMTP id S261464AbVDEBJD (ORCPT ); Mon, 4 Apr 2005 21:09:03 -0400 Subject: Re: [RFC 5/6]clean cpu state after hotremove CPU From: Li Shaohua To: Zwane Mwaikambo Cc: lkml , ACPI-DEV , Len Brown , Pavel Machek In-Reply-To: References: <1112580367.4194.344.camel@sli10-desk.sh.intel.com> Content-Type: text/plain Message-Id: <1112663194.17861.12.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 05 Apr 2005 09:06:34 +0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 39 On Tue, 2005-04-05 at 03:11, Zwane Mwaikambo wrote: > On Mon, 4 Apr 2005, Li Shaohua wrote: > > > Clean up all CPU states including its runqueue and idle thread, > > so we can use boot time code without any changes. > > Note this makes /sys/devices/system/cpu/cpux/online unworkable. > > > > #ifdef CONFIG_HOTPLUG_CPU > > #include > > + > > +#ifdef CONFIG_STR_SMP > > +extern void cpu_exit_clear(int); > > +#endif > > Perhaps change that ifdef to denote something which clearly shows that its > physical hotplug as we'll need this for other users too. Ok. > > +#ifdef CONFIG_STR_SMP > > +extern void do_exit_idle(void); > > +extern void cpu_uninit(void); > > +void cpu_exit_clear(int cpu) > > +{ > > + int sibling; > > + cpucount --; > > Is that protected by the cpu_control semaphore? cpu_exit_clear is called before the dead CPU ack CPU_DEAD, so it's finished before __cpu_die returns, which is protected by cpu_control. Maybe I should add comments for it. Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/