Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261308AbVDECDM (ORCPT ); Mon, 4 Apr 2005 22:03:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261535AbVDECDM (ORCPT ); Mon, 4 Apr 2005 22:03:12 -0400 Received: from fmr18.intel.com ([134.134.136.17]:43968 "EHLO orsfmr003.jf.intel.com") by vger.kernel.org with ESMTP id S261308AbVDECDI (ORCPT ); Mon, 4 Apr 2005 22:03:08 -0400 Subject: Re: [RFC 1/6]SEP initialization rework From: Li Shaohua To: Zwane Mwaikambo Cc: lkml , ACPI-DEV , Len Brown , Pavel Machek In-Reply-To: References: <1112580349.4194.331.camel@sli10-desk.sh.intel.com> Content-Type: text/plain Message-Id: <1112662825.17861.4.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 05 Apr 2005 09:00:25 +0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1425 Lines: 35 On Tue, 2005-04-05 at 03:10, Zwane Mwaikambo wrote: > On Mon, 4 Apr 2005, Li Shaohua wrote: > > > linux-2.6.11-root/arch/i386/kernel/smpboot.c | 6 ++++++ > > linux-2.6.11-root/arch/i386/kernel/sysenter.c | 10 ++++++---- > > linux-2.6.11-root/arch/i386/mach-voyager/voyager_smp.c | 6 ++++++ > > 3 files changed, 18 insertions(+), 4 deletions(-) > > > > diff -puN arch/i386/kernel/sysenter.c~sep_init_cleanup arch/i386/kernel/sysenter.c > > --- linux-2.6.11/arch/i386/kernel/sysenter.c~sep_init_cleanup 2005-03-28 09:32:30.936304248 +0800 > > +++ linux-2.6.11-root/arch/i386/kernel/sysenter.c 2005-03-28 09:58:20.703703792 +0800 > > @@ -26,6 +26,11 @@ void enable_sep_cpu(void *info) > > int cpu = get_cpu(); > > struct tss_struct *tss = &per_cpu(init_tss, cpu); > > > > + if (!boot_cpu_has(X86_FEATURE_SEP)) { > > + put_cpu(); > > + return; > > + } > > + > > Do you have systems like this? Is it really skipping SEP if the boot > processor doesn't have SEP? No, I haven't such system. This is the logic of original SEP initialization. If the CPU hasn't SEP, original logic doesn't call 'on_each_cpu(enable_sep_cpu,...)'. Thanks, Shaohua - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/