Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262238AbVDFQAa (ORCPT ); Wed, 6 Apr 2005 12:00:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262240AbVDFQAa (ORCPT ); Wed, 6 Apr 2005 12:00:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:17125 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S262238AbVDFQAW (ORCPT ); Wed, 6 Apr 2005 12:00:22 -0400 Date: Wed, 06 Apr 2005 18:00:20 +0200 Message-ID: From: Takashi Iwai To: Jeff Garzik Cc: perex@suse.cz, Jason Gaston , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.11.6 3/6] intel8x0: AC'97 audio patch for Intel ESB2 In-Reply-To: <4252EE82.9000605@pobox.com> References: <200504050810.10903.jason.d.gaston@intel.com> <4252EE82.9000605@pobox.com> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 43 At Tue, 05 Apr 2005 16:01:06 -0400, Jeff Garzik wrote: > > Jason Gaston wrote: > > Hello, > > > > This patch adds the Intel ESB2 DID's to the intel8x0.c file for AC'97 audio support. This patch was built against the 2.6.11.6 kernel. > > If acceptable, please apply. Note: This patch depends on the previous 1/6 patch for pci_ids.h > > > > Thanks, > > > > Jason Gaston > > > > Signed-off-by: Jason Gaston > > > > --- linux-2.6.11.6/sound/pci/intel8x0.c.orig 2005-03-28 09:29:48.611042184 -0800 > > +++ linux-2.6.11.6/sound/pci/intel8x0.c 2005-03-28 09:32:49.771501608 -0800 > > @@ -124,6 +125,9 @@ > > #ifndef PCI_DEVICE_ID_INTEL_ICH7_20 > > #define PCI_DEVICE_ID_INTEL_ICH7_20 0x27de > > #endif > > +#ifndef PCI_DEVICE_ID_INTEL_ESB2_13 > > +#define PCI_DEVICE_ID_INTEL_ESB2_13 0x2698 > > +#endif > > #ifndef PCI_DEVICE_ID_SI_7012 > > #define PCI_DEVICE_ID_SI_7012 0x7012 > > #endif > > (directed at the ALSA people, not Jason) > > These #ifdefs need to be removed from the mainline kernel sources. Do you mean to remove all these PCI_DEVICE_ID_* definitions (#ifndef, #define and #endif) from the driver part and put them in include/linux/pci_ids.h if not exist? Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/