Date: Thu, 7 Apr 2005 17:07:45 -0700
From: Greg KH <greg@kroah.com>
To: Rolf Eike Beer <eike-hotplug@sf-tec.de>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c
Message-ID: <20050408000745.GA7010@kroah.com>
References: <1112399271636@kroah.com> <200504021420.16772@bilbo.math.uni-mannheim.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200504021420.16772@bilbo.math.uni-mannheim.de>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1189
Lines: 28

On Sat, Apr 02, 2005 at 02:20:11PM +0200, Rolf Eike Beer wrote:
> Greg KH wrote:
> > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, eike-hotplug@sf-tec.de
> >
> > [PATCH] PCI Hotplug: remove code duplication in
> > drivers/pci/hotplug/ibmphp_pci.c
> >
> > This patch removes some code duplication where if and else have the
> > same code at the beginning and the end of the branch.
> 
> Greg, as you correctly pointed out this patch if broken. It could never reach 
> the if branch and always uses the else branch. Please drop this one and 
> review the patch I sent on March 21th to pcihp-discuss for inclusion. It 
> removes much more duplication and handles this case correctly. Sorry, it 
> looks like I forgot to CC you. I'll bounce this mail to you.

Hm, care to send me a patch that backs the old one out?  Or just one
that fixes it properly, I can't really revert the old patch, now that
I'm not using bitkeeper :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/